Bug 235942

Summary: [GTK][WPE] Switch to use ATSPI instead of ATK
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, annulen, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, ryuan.choi, samuel_white, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236036
https://bugs.webkit.org/show_bug.cgi?id=236215
Bug Depends on:    
Bug Blocks: 230253    
Attachments:
Description Flags
Patch
aperez: review+, aperez: commit-queue-
Patch aperez: review+

Carlos Garcia Campos
Reported 2022-02-01 01:26:58 PST
Use ATSPI by default.
Attachments
Patch (43.45 KB, patch)
2022-02-01 01:28 PST, Carlos Garcia Campos 		aperez: review+
aperez: commit-queue-
DetailsFormatted DiffDiff
Patch (43.86 KB, patch)
2022-02-01 01:34 PST, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2022-02-01 01:28:51 PST
Created attachment 450508 [details] Patch
Carlos Garcia Campos
Comment 2 2022-02-01 01:34:01 PST
Created attachment 450509 [details] Patch
Adrian Perez
Comment 3 2022-02-01 03:10:12 PST
Comment on attachment 450508 [details] Patch Patch LGTM, modulo making the style checker happy before landing. I am glad to see the default being switched to the new implementation \o/
Carlos Garcia Campos
Comment 4 2022-02-01 03:11:38 PST
(In reply to Adrian Perez from comment #3) > Comment on attachment 450508 [details] > Patch > > Patch LGTM, modulo making the style checker happy before landing. > > I am glad to see the default being switched to the new implementation \o/ Already submitted a new patch with the style issue fixed.
Adrian Perez
Comment 5 2022-02-01 03:13:16 PST
(In reply to Carlos Garcia Campos from comment #4) > (In reply to Adrian Perez from comment #3) > > Comment on attachment 450508 [details] > > Patch > > > > Patch LGTM, modulo making the style checker happy before landing. > > > > I am glad to see the default being switched to the new implementation \o/ > > Already submitted a new patch with the style issue fixed. You sir, are fast! 🚀️
Carlos Garcia Campos
Comment 6 2022-02-01 04:29:11 PST
Committed r288872 (246624@trunk): <https://commits.webkit.org/246624@trunk>
Note You need to log in before you can comment on or make changes to this bug.