Bug 243329

Summary: test-webkitpy is failing to install lupa-1.13.0 on Windows Python
Product: WebKit Reporter: Fujii Hironori <fujii>
Component: Tools / TestsAssignee: Fujii Hironori <fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, stephan.szabo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233734
https://bugs.webkit.org/show_bug.cgi?id=245810
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2022-07-28 18:32:34 PDT
webkitpy: Failed to install lupa-1.13.0! on WinCairo buildbot > ValueError: path '/home/runner/work/lupa/lupa/third-party/lua/lapi.c' cannot be absolute > Failed to install lupa-1.13.0! Buildbot: builder WinCairo-64-bit-WKL-Release-Tests build 7512 https://build.webkit.org/#/builders/60/builds/7512
Attachments
Patch (1.58 KB, patch)
2022-07-28 21:04 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-07-28 19:02:58 PDT
On Windows, "pip install lupa" just downloads a pre-compiled binary. PS D:\work\tmp> pip install lupa Collecting lupa Downloading lupa-1.13-cp39-cp39-win_amd64.whl (287 kB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 287.6/287.6 kB 8.9 MB/s eta 0:00:00 Installing collected packages: lupa Successfully installed lupa-1.13
Fujii Hironori
Comment 2 2022-07-28 19:13:18 PDT
lupa-1.13/lupa.egg-info/SOURCES.txt of lupa-1.13.tar.gz contains the someone's absolute path. > ... > /home/runner/work/lupa/lupa/third-party/lua/lapi.c > /home/runner/work/lupa/lupa/third-party/lua/lauxlib.c > /home/runner/work/lupa/lupa/third-party/lua/lbaselib.c > ... Unpacking lupa-1.13.tar.gz and invoking "python .\setup.py install" reported the same error. > ValueError: path '/home/runner/work/lupa/lupa/third-party/lua/lapi.c' cannot be absolute However, removing the 'lupa.egg-info' directory and invoking "python .\setup.py install" succeeded. 'lupa.egg-info' directory was regenerated and lupa.egg-info/SOURCES.txt contained my absolute path. > ... > D:/work/tmp/lupa-1.13/third-party/lua/lapi.c > D:/work/tmp/lupa-1.13/third-party/lua/lauxlib.c > D:/work/tmp/lupa-1.13/third-party/lua/lbaselib.c > ...
Fujii Hironori
Comment 3 2022-07-28 19:37:15 PDT
244901@main (bug#233734) added the implementation and unit tests of commits.webkit.org.
Fujii Hironori
Comment 4 2022-07-28 21:04:17 PDT
Created attachment 461288 [details] Patch
Fujii Hironori
Comment 5 2022-08-01 13:06:16 PDT
Comment on attachment 461288 [details] Patch Thank you.
EWS
Comment 6 2022-08-01 13:42:40 PDT
Committed 253008@main (5df171bce18e): <https://commits.webkit.org/253008@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461288 [details].
Radar WebKit Bug Importer
Comment 7 2022-08-01 13:45:24 PDT
<rdar://problem/97933765>
Note You need to log in before you can comment on or make changes to this bug.