Bug 285935
| Summary: | REGRESSION(270688@main): Text is not displayed if it is formatted with OpenType-SVG color fonts | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=221744 https://bugs.webkit.org/show_bug.cgi?id=260181 |
||
Said Abou-Hallawa
Open lennypickettmusic.com
Result: The navigation bar with the text "LENNY PICKETT MUSIC" is not displayed.
drawDisplayListItems() was added to GraphicsContext and its subclasses in 270688@main to transfer a DisplayList in one IPC to GPUProcess. It turned out this is problematic when RenderingResources are referenced from the items.
We do not transfer local ImageBuffers to GPUProcess and DisplayList::Recorder should fail to record these items. It is supposed to fall back to GraphicsContext which transfers the local ImageBuffers to ShareableBitmaps before calling the corresponding NativeImage functions.
The problem is this does not happen with individual items in DisplayList::Recorder::drawDisplayListItems(). We keep them referencing ImageBuffers although RemoteDisplayListRecorderProxy::recordResourceUse() fails to record the local ImageBuffers.
The fix is to revert 270688@main. Reverting this change should not have an effect on MotionMark - Design sub-test. All the text runs in this sub-tests have only one DrawDecomposedGlyphs item which references a Font resource. So replaying back this item in WebProcess and sending it to GPUP individually should be the same as transferring the one-item list and replaying it back in GPUProcess.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Said Abou-Hallawa
rdar://137496217
Said Abou-Hallawa
https://github.com/WebKit/WebKit/pull/39016
Said Abou-Hallawa
Committed 288980@main (37ebf36): https://commits.webkit.org/288980@main
Reviewed commits have been landed. Closing PR #39016 and removing active labels.